pgsql: Fix memory leak when first string conversion fails #20213
Conversation
If the first string conversion fails, then i==0, but memory was still allocated for `params`. However, we skip freeing `params` when i==0.
| } | ||
| efree(params); | ||
| } | ||
| efree(params); |
There was a problem hiding this comment.
was it the "point of contention" ? in that case you can just change it place.
There was a problem hiding this comment.
I don't understand what you mean
There was a problem hiding this comment.
if num_params == 0 then params array was never freed
There was a problem hiding this comment.
Yes, e.g. if you exit here in the first iteration when i==0, then params is never freed:
Lines 1130 to 1131 in 28ce1b0
Removing the num_params > 0 check fixes it. It is a useless check anyway: the loop will already check this and we should not do the check for freeing params.
There was a problem hiding this comment.
sure what I meant originally was just putting the efree(params); out of the if block would have worked as well but that s detail.
There was a problem hiding this comment.
I see. That works too but since I'm touching the function anyway I thought I'd just remove the check
There was a problem hiding this comment.
Yes I just also saw your other PR, makes sense
2 participants
If the first string conversion fails, then i==0, but memory was still allocated for
params. However, we skip freeingparamswhen i==0.